Incompatible with clappr 0.3.9

[bp2008]

I've tried to get this plugin to work with clappr 0.3.9, and it just failed silently.

After some investigation, I was able to solve it by making this change to the plugin source:

OLD:

  bindEvents() {
    this.listenTo(this.core.mediaControl, Events.CORE_ACTIVE_CONTAINER_CHANGED, this.reload);
    this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_RENDERED, this.render);
    this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_HIDE, this.hideContextMenu);
    this.listenTo(this.core.mediaControl, PlaybackRatePlugin.MEDIACONTROL_PLAYBACKRATE, this.updatePlaybackRate);
  }

  unBindEvents() {
    this.stopListening(this.core.mediaControl, Events.MEDIACONTROL_CONTAINERCHANGED);
    this.stopListening(this.core.mediaControl, Events.MEDIACONTROL_RENDERED);
    this.stopListening(this.core.mediaControl, Events.MEDIACONTROL_HIDE);
  }

NEW:

  bindEvents() {
    this.listenTo(this.core, Events.CORE_ACTIVE_CONTAINER_CHANGED, this.reload);
    this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_RENDERED, this.render);
    this.listenTo(this.core.mediaControl, Events.MEDIACONTROL_HIDE, this.hideContextMenu);
    this.listenTo(this.core.mediaControl, PlaybackRatePlugin.MEDIACONTROL_PLAYBACKRATE, this.updatePlaybackRate);
  }

  unBindEvents() {
    this.stopListening(this.core, Events.CORE_ACTIVE_CONTAINER_CHANGED);
    this.stopListening(this.core.mediaControl, Events.MEDIACONTROL_CONTAINERCHANGED);
    this.stopListening(this.core.mediaControl, Events.MEDIACONTROL_RENDERED);
    this.stopListening(this.core.mediaControl, Events.MEDIACONTROL_HIDE);
  }

[bp2008]

The event unbinding still looks wrong, but meh... it works now where it didn't before.

[bikegriffith]

Thanks for the report. Feel free to open a PR to improve the event binding/unbinding if you have ideas.

[bp2008]

Alas, clappr doesn't have good documentation for plugins, so all I know I learned by looking at this and other plugins. It just looks like an event that was never bound is being unbound (Events.MEDIACONTROL_CONTAINERCHANGED), and an event that was bound is not being unbound (PlaybackRatePlugin.MEDIACONTROL_PLAYBACKRATE)