Today while out and about using BikeHopper, I noticed that when I changed my plans along the way and changed my destination, the "Current Location" start point of the route provided was stale.
This looks like a bug in locationsSubmitted. It's always falling back to a point if present, which it should do for Custom points or geocoded points, but for "Current Location," we should always geolocate, relying on the browser's caching (via the maximumAge param and the value provided for that in features/geolocation.js).
With this change, any time you fetch a new route, your "Current Location" will be updated first.
Today while out and about using BikeHopper, I noticed that when I changed my plans along the way and changed my destination, the "Current Location" start point of the route provided was stale.
This looks like a bug in
locationsSubmitted. It's always falling back to apointif present, which it should do for Custom points or geocoded points, but for "Current Location," we should always geolocate, relying on the browser's caching (via themaximumAgeparam and the value provided for that infeatures/geolocation.js).With this change, any time you fetch a new route, your "Current Location" will be updated first.