bikehopper / bikehopper-ui

Friendly bike+transit directions (frontend)
Other
26 stars 1 forks source link

update github actions for node@20 #306

Closed Andykmcc closed 7 months ago

graue commented 7 months ago

where are these actions defined?

Andykmcc commented 7 months ago

they are all public actions defined by either github or docker. so actions/checkout@v4 can out found at https://github.com/actions/checkout. The same pattern applies to all of them.

graue commented 7 months ago

which one makes the build use Node 20?

Andykmcc commented 7 months ago

scroll down to the Annotations section here. https://github.com/bikehopper/bikehopper-ui/actions/runs/7719972371

graue commented 7 months ago

I see. So this is not about using Node 20 to build or run bikehopper-ui, but upgrading the version of Node used within the implementation of those actions. (correct me if I'm wrong)

Andykmcc commented 7 months ago

that is my understanding.

Andykmcc commented 7 months ago

this change will need to be applied to all of our repos that make a container. maybe others too