Typings for state, actions

bikehopper / bikehopper-ui

Friendly bike+transit directions (frontend)

Other

26 stars 1 forks source link

Typings for state, actions #360

Closed graue closed 3 months ago

graue commented 3 months ago

Picking up what #349 started

Known limitations:

TS is ignoring the import of @turf/helpers (in routeParams) because something is wrong with that library's declaration.
Not confident the type of the GraphHopper route response is 100% accurate about what is and isn't nullable.
After doing this, I read that we're not supposed to create unions of action types in Redux. But it seems good enough, and the alternative is extremely verbose unless/until we switch to Redux Toolkit (#359).

graue commented 3 months ago

Because this is a large change (1300 lines already) I've tried to minimize the surface area which is why I prefer not to change the capitalization of things and make everything enums (which requires changing all the files that use those constants) or change the comment style to allow for tooltips in an IDE I don't use. Not necessarily opposed to those changes in the future.

I prefer to err on the side of fewer type aliases/intermediate types so it's easier to grok the real structure of the data.

abhumbla commented 3 months ago

Not necessarily opposed to those changes in the future.

ok, I can go through and put in a cleanup PR after you merge this