Closed graue closed 3 months ago
i think at some point i will make a test container for this project. basically just a dockerfile that calls lint and any tests that might come to be. it will be the home of all the prebuild checks. then we can build+run said test container in the github action, if it exits with 0 then move on with building of the prod image, otherwise bale. This would allow us to keep the production images free of dev dependencies.
Tweaks look great!
I had read somewhere that project: true
was needed for enabling typed checks in TypeScript-ESLint (which we are not ready to do yet, it creates 130 errors), but now I can't find where it says that, or any documentation of what that field does. Ok.
npm run lint
was not scanning ts and tsx files.This also turns off TS's unused locals/args warning since it is duplicative of this more configurable lint rule:
https://typescript-eslint.io/rules/no-unused-vars
I have not turned on the Typescript-ESLint recommended rules yet because it produces lots of errors that will need to be dealt with in time.