search

bikehopper / graphhopper

Open source routing engine for OpenStreetMap. Use it as Java library or standalone web server.
https://www.graphhopper.com/open-source/
Apache License 2.0
3 stars 0 forks source link

No bikes on California St cable car in SF #125

Closed graue closed 1 year ago

graue commented 1 year ago

This also changes how our hardcoded bikes_allowed overrides work. Instead of hardcoding the route ID, everything for agency "SF" that isn't a bus (route_type 3) or trolley bus (in theory 11, although SFMTA currently uses 3 for all buses, but if they switched to using 11 for trolley buses this code would still work), is marked as not allowing bikes.

Verified this route that's currently using the cable car in production doesn't, in this branch, and it still avoids SFMTA light rail, but still takes SFMTA and County Connection buses.

Fixes #121. The specific change was SFMTA's GTFS started using a route ID of SF:CA instead of SF:C.

graue commented 1 year ago

I'd like to keep the comment. We are still hardcoding Bay Area specific information which would be better not to do and may cause problems if another region spins up a BikeHopper instance and their local GTFS feed refers to a totally different agency as SF or CC. Thanks for the review!