search

bikehopper / graphhopper

Open source routing engine for OpenStreetMap. Use it as Java library or standalone web server.
https://www.graphhopper.com/open-source/
Apache License 2.0
3 stars 0 forks source link

GH #113: stop_name isn't required #136

Closed rsarathy closed 4 months ago

rsarathy commented 4 months ago

Logs w/o change:

2024-04-23 10:23:06.336 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Loading GTFS table stop_times from stop_times.txt
2024-04-23 10:23:08.005 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 500.0k
2024-04-23 10:23:09.571 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 1.0M
2024-04-23 10:23:10.733 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 1.5M
2024-04-23 10:23:11.782 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 2.0M
2024-04-23 10:23:12.757 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 2.5M
2024-04-23 10:23:14.027 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 3.0M
2024-04-23 10:23:15.106 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 3.5M
2024-04-23 10:23:16.401 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 4.0M
2024-04-23 10:23:17.401 [main] ERROR com.conveyal.gtfs.GTFSFeed - stops line 104, field 'stop_name': No value supplied for a required column.
[more of the same errors, omitted]
2024-04-23 10:23:17.405 [main] ERROR com.conveyal.gtfs.GTFSFeed - stops line 1481, field 'stop_name': No value supplied for a required column.
2024-04-23 10:23:17.420 [main] INFO  com.graphhopper.gtfs.GtfsStorage - Calendar range covered by all feeds: 2019-09-30 till 2099-12-31

Logs w/change:

2024-04-23 10:54:38.041 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Loading GTFS table stop_times from stop_times.txt
2024-04-23 10:54:39.225 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 500.0k
2024-04-23 10:54:40.458 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 1.0M
2024-04-23 10:54:41.526 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 1.5M
2024-04-23 10:54:42.542 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 2.0M
2024-04-23 10:54:43.654 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 2.5M
2024-04-23 10:54:44.812 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 3.0M
2024-04-23 10:54:46.262 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 3.5M
2024-04-23 10:54:47.571 [main] INFO  c.conveyal.gtfs.model.Entity$Loader - Record number 4.0M
2024-04-23 10:54:48.746 [main] INFO  com.graphhopper.gtfs.GtfsStorage - Calendar range covered by all feeds: 2019-09-30 till 2099-12-31
rsarathy commented 4 months ago

Code looks good, thanks!

What's happening with the git history? Can you get rid of those 4 extra commits? Or just squash and merge would work I guess

Yeah I'm not sure, might be something to do with how I made the branches locally. In any case I was just going to do a squash & merge.