search

bikehopper / graphhopper

Open source routing engine for OpenStreetMap. Use it as Java library or standalone web server.
https://www.graphhopper.com/open-source/
Apache License 2.0
3 stars 0 forks source link

Add more cycleway values that are used commonly #21

Closed hcourt closed 2 years ago

hcourt commented 2 years ago

I ran through all the bay area network and found some additional cycleway values that appear to be valid based on the wiki. Hence this PR to add them.

Below are the other values I found in the bay area network that I believe are tagging mistakes based on reading the wiki, and a suggested change by me. We can make these changes ourselves potentially; it would be nice to improve the data directly. With some additional work I can make a list of all these incorrectly tagged ways.

In addition, I found and want to handle values like "track;lane", but only found this in one place.

graue commented 2 years ago

Does just adding these to the enum have an effect, or is this preparatory to further changes?

Should "left" and "right" be here? It looks like "cycleway=left" or "cycleway=right" wouldn't be meaningful, but rather it's used like "cycleway:left=track" "cycleway:right=shared_lane" (in this example, the "left" side has a protected bike lane while the "right" side has sharrows). https://wiki.openstreetmap.org/wiki/Key:cycleway

hcourt commented 2 years ago

@graue

Does just adding these to the enum have an effect, or is this preparatory to further changes?

The effect is, when we request the Cycleway detail from graphhopper, it will provide these actual text values properly instead of assigning them "other".

Should "left" and "right" be here? It looks like "cycleway=left" or "cycleway=right" wouldn't be meaningful, but rather it's used like "cycleway:left=track" "cycleway:right=shared_lane" (in this example, the "left" side has a protected bike lane while the "right" side has sharrows). https://wiki.openstreetmap.org/wiki/Key:cycleway

Actually both kinds of tagging are in use in the bay area, and both are documented in the wiki. Here's where left/right/both are documented for tag values generally. The syntactic meaning is that there is a cycleway in the left or right side of the way. For example, bike lanes are usually on the right side of the direction of travel, but sometimes can be on the left (I can think of one location in the wiggle).