search

bikehopper / graphhopper

Open source routing engine for OpenStreetMap. Use it as Java library or standalone web server.
https://www.graphhopper.com/open-source/
Apache License 2.0
3 stars 0 forks source link

Reading edges the wrong way on interpolated legs #67

Closed abhumbla closed 3 months ago

abhumbla commented 2 years ago

for some reason the code to turn interpolated transfers into legs is failing a check making sure the edge is being read in the correct direction. not sure why this is happening. graphhopper upstream might have fixed this already. we should check that. I've commented out the check for now, doesn't seem to cause any problems reverse-edge-error

rsarathy commented 3 months ago

I wasn't able to reproduce this with the above query and the code uncommented. The edge in question is Bailey Road in Pittsburg, and I tried routing through it to produce the exception, but all queries succeeded. Are there other ways to exercise this check?

abhumbla commented 3 months ago

hmm, maybe this got fixed with the change we made yesterday to the interpolated transfers? I would play around with this but if we can't replicate, I think it's fine to uncomment the check and close the issue

rsarathy commented 3 months ago

Just reproduced this with one of our cases (Jack London Square -> Levi's Stadium departing at 21 May 2024 14:30) that we used to debug #68. Scott's change yesterday fixes this issue too.