search

bikeindex / bike_index

All the code for Bike Index, because we love you
https://bikeindex.org
GNU Affero General Public License v3.0
274 stars 70 forks source link

Add spec to verify process_in_background for carrierwave_backgrounder #2564

Closed sethherr closed 2 months ago

sethherr commented 2 months ago

This is the test to demonstrate the problem with upgrading https://github.com/bikeindex/bike_index/pull/2557

sethherr commented 2 months ago

It seems like the test still passes when carrierwave is upgraded (PR for carrierwave upgrade), and it passes in click testing.

I'm not sure why this passes even though it didn't work in the upgrade - maybe something to do with image uploading vs local images?

You can upload an image at admin/recovery_displays/new and test that it works (note, after you create the recovery display, you'll be directed to admin/recoveries - which won't include your new recovery_display - you'll have to navigate to admin/recovery_displays to see it).

sethherr commented 2 months ago

Merging with the carrierwave upgrade because something is better than nothing.