search

bikeshaving / crank

The Just JavaScript Framework
https://crank.js.org
MIT License
2.7k stars 75 forks source link

Allow overriding xmlns #268

Closed canadaduane closed 1 year ago

canadaduane commented 1 year ago

A foreignObject element within an svg tag should not lose its SVG_NAMESPACE, because it is still an SVG element.

In addition, children of a foreignObject element should be allowed to specify their xmlns, since it is likely they will be of some other namespace than the foreignObject, e.g. a child div would need to be xhtml.

This PR allows such child elements to specify their xmlns, when needed.

brainkim commented 1 year ago

Thank you for being proactive with this PR! I will review it ASAP and I apologize about any blockers.

canadaduane commented 1 year ago

Ok, updated based on your comments @brainkim. Thanks for the feedback & for considering this change.

brainkim commented 1 year ago

F- IT, I’LL FIX THE LINT ERROR ON MAIN

brainkim commented 1 year ago

Shipped in 0.5.6

canadaduane commented 1 year ago

Thanks!