search

bikeshedder / tusker

PostgreSQL migration management tool
The Unlicense
213 stars 17 forks source link

Added ability for list of patterns for filename #26

Closed whalespine closed 2 years ago

whalespine commented 2 years ago

Added ability to specify a list in tusker.toml for schema.filename

[schema]
filename = ["schema/**/*.*sql","procs/**/*.pgsql"]

TODO: Backwards compatibility support for a single string.

bikeshedder commented 2 years ago

Once you've added the backwards compatibility for single strings I'm happy to merge this. :partying_face:

whalespine commented 2 years ago

How's that look?

bikeshedder commented 2 years ago

Looks good to me.

If you find some time an entry in the CHANGELOG.md would be nice and maybe some explanation in the README.md. Also I think it would be nice if the list of patterns was also supported for the migrations, no?

If you don't find time to do that I'll update those two files myself.

bikeshedder commented 2 years ago

lgtm. Just let me know if you want to fix the few nitpicks I pointed out or I'll merge it as is and fix those myself.

Thanks a lot for the work you put into this. :+1:

whalespine commented 2 years ago

I think that covers everything. Thanks for your help and patience.

bikeshedder commented 2 years ago

I just released Tusker 0.5.0 including your changes: https://pypi.org/project/tusker/0.5.0/

Thanks a lot for your contribution! :+1: