search

bilal-fazlani / tracker-enabled-dbcontext

Tracker-enabled DbContext offers you to implement full auditing in your database
https://tracker-enabled-dbcontext.bilal-fazlani.com/
Other
217 stars 110 forks source link

Using of deprecated dependency EntityFramework.MappingAPI #155

Closed richieeeeeeee closed 5 years ago

richieeeeeeee commented 6 years ago

Hi, trackerendabledbcontext.common requires EntityFramework.MappingAPI, which is deprecated: https://www.nuget.org/packages/EntityFramework.MappingAPI/ Is it possible to remove/replace this dependency? Thanks!

tedbcsgpro commented 6 years ago

Saw that mappingAPI was removed 15 days ago. Lookup forward to an updated NuGet package without this dependency. Thank you.

bilal-fazlani commented 6 years ago

Yes, I will do this tonight

vmtco commented 6 years ago

I'm waiting for you

furier commented 6 years ago

me2

minoseah629 commented 6 years ago

thank you. looking forward to a new package in nuget.

furier commented 6 years ago

still waiting...

jannohordijk commented 6 years ago

Please solve this. I just tried your package and got the same error (Dutch):

"Kan bestand of assembly EntityFramework.MappingAPI, Version=6.1.0.9, Culture=neutral, PublicKeyToken=7ee2e825d201459e of een van de afhankelijkheden hiervan niet laden. De manifestdefinitie van de gevonden assembly komt niet overeen met de assembly-verwijzing. (Uitzondering van HRESULT: 0x80131040)" | string

vmtco commented 6 years ago

Use this command in Package Manager Console to solve error Update-Package EntityFramework.MappingAPI -Version 6.1.0.9 until resolve it

jannohordijk commented 6 years ago

Thank you, that did the trick. Best regards!

merccat commented 6 years ago

Thank you for the work around as well and thanks for a great package! Looking forwarded to an updated version without the dependency.

Edit: While tracking down another issue I was experiencing I noticed that the dependency on MappingAPI seems to have been removed from the latest code base (yay). Also I am no longer encountering the object reference error with the latest code vs the nuget package so whatever that was seems to have been resolved as well (double-yay). Is the current code reasonably stable and just not yet published to Nuget pending more items you want to include or is there another reason to avoid it pending the next release? Thanks!

traelthompson75 commented 6 years ago

I tried your suggested fix with the NuGet command Update-Package EntityFramework.MappingAPI -Version 6.1.0.9 and I am still getting the error.... Any help would be greatly appreciated.

Error: Could not load file or assembly 'EntityFramework.MappingAPI, Version=6.1.0.9, Culture=neutral, PublicKeyToken=7ee2e825d201459e' or one of its dependencies. The system cannot find the file specified.

furier commented 6 years ago

make sure the version is actually changed, sometimes if you have other dependencies which depend on the newer version it will upgrade it for you when downgrading which is kind of annoying as you would think you downgraded it but you didn't... also manually clear out packages and global packages cache, bin/obj folders etc and try again.

tor. 14. jun. 2018 kl. 19:01 skrev Trae Thompson notifications@github.com:

I tried your suggested fix with the NuGet command Update-Package EntityFramework.MappingAPI -Version 6.1.0.9 and I am still getting the error.... Any help would be greatly appreciated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bilal-fazlani/tracker-enabled-dbcontext/issues/155#issuecomment-397367111, or mute the thread https://github.com/notifications/unsubscribe-auth/AAva1y4bFMHhAnOHNR_N1muTQxlBg70Nks5t8pcFgaJpZM4R3YSi .

traelthompson75 commented 6 years ago

Ok. Thank you so much! After going through every folder. And deleting out that worked!!!

furier commented 6 years ago

you are welcome :)

tor. 14. jun. 2018 kl. 20:22 skrev Trae Thompson notifications@github.com:

Ok. Thank you so much! After going through every folder. And deleting out that worked!!!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bilal-fazlani/tracker-enabled-dbcontext/issues/155#issuecomment-397391793, or mute the thread https://github.com/notifications/unsubscribe-auth/AAva19XqMQIZ32ii5EvEvM6w28vsyDo8ks5t8qnRgaJpZM4R3YSi .

asulwer commented 6 years ago

I have already removed this from my branch.

furier commented 6 years ago

have you created a PR for this then?

ons. 18. jul. 2018 kl. 22:39 skrev Aaron Sulwer notifications@github.com:

I have already removed this from my branch.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bilal-fazlani/tracker-enabled-dbcontext/issues/155#issuecomment-406066766, or mute the thread https://github.com/notifications/unsubscribe-auth/AAva18bu7cb5fpiVZ7Af40cLffpJJebjks5uH50QgaJpZM4R3YSi .

bilal-fazlani commented 6 years ago

I think there is a PR. https://github.com/bilal-fazlani/tracker-enabled-dbcontext/pull/158

@asulwer let's resolve the conflicts first. would you be able to do that or will need any permissions on the repo?

asulwer commented 6 years ago

@bilal-fazlani I removed all of those conflicts in a previous PR that has been merged into the main branch. Version number wasn't changed.

PR#158 is a huge change to support Core 2.0 (untested with 2.1). The entire solution was restructured. I am missing test for Core. I started a web project to test some features. The current committed fork is up to date, as of yesterday

I wouldn't mind having my privileges being elevated so I can merge this PR into the main branch.

furier commented 6 years ago

Could also just publish the core version as prerelease to nuget if not yet satisfied.

Den tor. 19. jul. 2018, 18.17 skrev Aaron Sulwer notifications@github.com:

@bilal-fazlani https://github.com/bilal-fazlani I removed all of those conflicts in a previous PR that has been merged into the main branch. Version number wasn't changed.

PR#158 is a huge change to support Core 2.0 (untested with 2.1). The entire solution was restructured. I am missing test for Core. I started a web project to test some features. The current committed fork is up to date, as of yesterday

I wouldn't mind having my privileges being elevated so I can merge this PR into the main branch.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bilal-fazlani/tracker-enabled-dbcontext/issues/155#issuecomment-406333851, or mute the thread https://github.com/notifications/unsubscribe-auth/AAva10ADJxCrvn5UXljCx9qQOtQX8HD-ks5uILE2gaJpZM4R3YSi .

bilal-fazlani commented 6 years ago

@asulwer

Yeah, as @furier suggested, I am also thinking, two parallel packages make sense. The non-core version of this package still might continue to evolve with non-core version of EF.

Let's maintain a branch for core version and continue to deploy the core version of nuget from that branch.

the current non-core package runs tests on every commit but does not have a automated deployment provision. I have been doing that manually so far and have not been able to do one since I don't have a windows machine anymore. Anyways, with the core version, let's setup a different pipeline to build, test and deploy using appveyor.

I can share my nuget key with you so we can share the deployment ownership. thoughts?

asulwer commented 6 years ago

I have already deployed the Core version to nuget. I please let me know if I did this incorrectly.

guillaumejay commented 6 years ago

I think sharing deployment ownership and repo would be best. Are we going to see an updated nuget for the .net 4.x version ? (mostly for removing the mappingAPI)

minoseah629 commented 6 years ago

TrackerEnabledDbContext has a Dependency to its common nuget package.

Common still has the dependency of EntityFramework.MappingAPI 6.1.0.9

image

alex-milburn commented 6 years ago

Same issue as minoseah629

guillaumejay commented 6 years ago

I solved by downloading the current code source and reference it directly, but I'd rather have a updated nuget package.

asulwer commented 6 years ago

I do not think that the nuget package has been updated. The Core version that I created does have it removed and IS a nuget package

StevenOwenNell commented 6 years ago

Is there any resolution to this yet?

StevenOwenNell commented 6 years ago

@asulwer @bilal-fazlani I see that the dependency has been removed in the project - could you please update the nuget package?

StevenOwenNell commented 6 years ago

@guillaumejay Would you care to share exactly how you did that, please?

asulwer commented 6 years ago

@StevenNell use nuget to get the latest that supports Core 2+

minoseah629 commented 6 years ago

@bilal-fazlani, any update to generate the nuget package?

ghost commented 6 years ago

Use this command in Package Manager Console to solve error Update-Package EntityFramework.MappingAPI -Version 6.1.0.9 until resolve it...

The above no longer works as EntityFramework.MappingAPI -Version 6.1.0.9 has been removed!

Could you update the nuget package as your library is not usable in it's current package.

JardarM commented 6 years ago

We would be greatfull if the nuget package could be updated.

jwindhor commented 6 years ago

Dear Team, We really love your solution and have it incorporated in all our enterprise solutions!

However, as you know it has now reached a critical point where the existing package and its dependencies are no longer functional.

Do you have any ETA on this updated package? Please advise ASAP so we can determine a path forward and ensure no business interruptions.

Thanks in advance.

bilal-fazlani commented 5 years ago

This should be resolved now thanks to @Askolein