search

bilal-fazlani / tracker-enabled-dbcontext

Tracker-enabled DbContext offers you to implement full auditing in your database
https://tracker-enabled-dbcontext.bilal-fazlani.com/
Other
217 stars 110 forks source link

Update to newer csproj version #171

Closed jbaig closed 4 years ago

jbaig commented 4 years ago

Closes #168 This involved only changing the csproj files for the library and unit tests. The SampleLogMaker site was left alone and should still work as is. The TrackerEnabledDbContext.Identity was also left to use net45 since it is specific to be used for Asp.Net Identity.

jbaig commented 4 years ago

It appears the sql connection string for appveyor is actually pulled from somewhere else besides the appveyor.yml. Probably it is in a Project -> Settings -> Environment. If it is, can you update them to match the appveyor.yml in the PR?
The Visual Studio 2019 image in appveyor only has access to mssql2017 and not mssql2014.

bilal-fazlani commented 4 years ago

Sure, will do. Might need a day or two though cos I am on vacation.

bilal-fazlani commented 4 years ago

Looking into it now

bilal-fazlani commented 4 years ago

@jbaig The build is green now.

Apparently the connection strings were present at 2 places: Appveyor interface and Appveyor conf file. Conf was being overridden by interface values and it was using the connection string for 2014 sql version. I have deleted the environment variables from appveyor interface and the build is now green.

Merging the PR

jbaig commented 4 years ago

Awesome thank you.