bilalcaliskan / nginx-conf-generator

A fancy tool which manages Nginx configuration according to Kubernetes NodePort type services
Apache License 2.0
4 stars 0 forks source link

re-enable unit tests on macos #51

Open bilalcaliskan opened 2 years ago

bilalcaliskan commented 2 years ago

Unit tests on macos are failing since directory structure of nginx on macos is different than ubuntu.

we should be able to override command line flags for different distribution. maybe we can override command line arguments with environment variables.

As a result, we should be able to pass below command line flag for only macos:

--templateOutputFile=/etc/nginx/nginx.conf.default
github-actions[bot] commented 1 year ago

This bot triages issues and PRs according to the following rules: - After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the issue is closed. You can: - Make a comment to remove the stale label and show your support. The 60 days reset. - If an issue has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interseted in reopening

github-actions[bot] commented 1 year ago

This bot triages issues and PRs according to the following rules: - After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the issue is closed. You can: - Make a comment to remove the stale label and show your support. The 60 days reset. - If an issue has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interseted in reopening

github-actions[bot] commented 1 year ago

This bot triages issues and PRs according to the following rules: - After 180d of inactivity, lifecycle/stale is applied. - After 90d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the issue is closed. You can: - Make a comment to remove the stale label and show your support. The 180d days reset. - If an issue has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interseted in reopening

github-actions[bot] commented 8 months ago

This bot triages issues and PRs according to the following rules: - After 180d of inactivity, lifecycle/stale is applied. - After 90d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the issue is closed. You can: - Make a comment to remove the stale label and show your support. The 180d days reset. - If an issue has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interseted in reopening