Closed GoogleCodeExporter closed 9 years ago
patches
Original comment by samuel.v...@gmail.com
on 22 Nov 2011 at 11:15
Attachments:
What is the actual behavior of nts reading corrupted files?
Can you attach a sample of some "corrupted" data?
Original comment by diegogu...@gmail.com
on 22 Nov 2011 at 11:37
The sample shapefile you sent, was it created using NTS?
Original comment by felix.ob...@netcologne.de
on 28 Nov 2011 at 1:50
x felix
>No idea which software they come from.
looks that isn't data built with NTS
Original comment by diegogu...@gmail.com
on 28 Nov 2011 at 2:11
No that data was not generated with NTS. I know the data is in fact wrong. But
my problem is that NTS doesn't complain at all and it represents the data
completely wrong. Imho that should not be the case. If that counter does not
match the assumed header length either NTS should complain that the file is
corrupt or reset the counter to that assumed header length.
As Excel, ArcGIS and others don't seem to have any problems with this file I
would assume that the 'increase_robustness_patch.txt' isn't all that bad...
Original comment by samuel.v...@gmail.com
on 28 Nov 2011 at 4:29
I just wanted to make sure we are not fixing a bug we introduced ourselves,
without fixing the bug, too.
Original comment by felix.ob...@netcologne.de
on 28 Nov 2011 at 4:38
I agree that show invalid data is a wrong thing, but your patch needs to be
tested, so having also some sample data to check can be useful :)
Original comment by diegogu...@gmail.com
on 28 Nov 2011 at 4:39
@diego: I got a sample file
Original comment by felix.ob...@netcologne.de
on 28 Nov 2011 at 4:46
the data I gave you in the email does demonstrate the behavior.
Original comment by samuel.v...@gmail.com
on 28 Nov 2011 at 4:46
fixed as of r782
Original comment by felix.ob...@netcologne.de
on 28 Nov 2011 at 5:43
Original issue reported on code.google.com by
samuel.v...@gmail.com
on 22 Nov 2011 at 11:14