search

bilby-dev / bilby

A unified framework for stochastic sampling packages and gravitational-wave inference in Python.
https://bilby-dev.github.io/bilby/
MIT License
60 stars 71 forks source link

GW-specific result object #309

Closed bilby-bot closed 1 month ago

bilby-bot commented 6 years ago

In GitLab by @git.ligo:gregory.ashton on Nov 14, 2018, 00:08

In #230, @git.ligo:charlie.hoy suggested adding the approximant to the result object and that is a good idea. More generally, I can imagine there being a number of CBC-specific information we'd like to include and also GW-specific methods we'd like the result object to have (for example, a plot_skymap method).

Keeping with the 1st amendment, separation of core and gw, this will require a special "bilby.gw.GWResult" object to be created which inherits from bilby.core.Result, but adds the additional data to store and new methods.

This would make a good issue for someone to pursue if you want to get to grips with the internals of the bilby results classes.

bilby-bot commented 5 years ago

In GitLab by @git.ligo:gregory.ashton on Jan 8, 2019, 11:23

created merge request !331 to address this issue

bilby-bot commented 5 years ago

In GitLab by @git.ligo:gregory.ashton on Jan 24, 2019, 01:58

closed via commit 6dd4a238ac1bbb2d2042938e8f269560b34f558a

bilby-bot commented 5 years ago

In GitLab by @git.ligo:gregory.ashton on Jan 24, 2019, 01:58

closed via merge request !331

bilby-bot commented 5 years ago

In GitLab by @git.ligo:gregory.ashton on Jan 24, 2019, 05:36

mentioned in commit 6dd4a238ac1bbb2d2042938e8f269560b34f558a