search

bilby-dev / bilby

A unified framework for stochastic sampling packages and gravitational-wave inference in Python.
https://bilby-dev.github.io/bilby/
MIT License
68 stars 75 forks source link

Service Desk (from 201921160007@mail.bnu.edu.cn): suspected error report #587

Closed bilby-bot closed 1 month ago

bilby-bot commented 4 years ago

In GitLab by @git.ligo:support-bot on Sep 21, 2020, 08:10

To whom it may concern:

Hi ! I'm Guo, a graduate student from Beijing Normal University. I'm not sure if this is an error for bilby: When I try to use bilby to generate a BBH waveform in 3 detectors: ... ifos = bilby.gw.detector.InterferometerList(['H1', 'L1', 'V1']) ifos.inject_signal(waveform_generator=waveform_generator, parameters=injection_parameters)

... The second line will output 3 h_plus and h _corss. But h_plus in 3 detectors are all the same, so does h_cross. I wonder if this is an error? If not, how can we generate a BBH waveform when we already got injection parameters?

I would appreciate it if you can help me with the problem.

Best, Weichangfeng Guo

bilby-bot commented 4 years ago

In GitLab by @git.ligo:gregory.ashton on Sep 22, 2020, 11:38

Hi Guo,

That doesn't sound correct, but I'm unable to reproduce the issue from your description. I've invited you to the Slack channel. Can you either post (either here or on Slack) an example showing how to reproduce the issue?

Cheers,

Greg

bilby-bot commented 4 years ago

In GitLab by @git.ligo:gregory.ashton on Sep 24, 2020, 20:18

Ah, I think I see what is happening now that I look at this again. The inject_signal method returns the injection_polarizations, this simply the generated waveform (which is identical between detectors), not the detector response which is performed here.

Does that make sense?

bilby-bot commented 4 years ago

In GitLab by @git.ligo:support-bot on Sep 25, 2020, 13:28

Hi Greg,

Thanks for your advice, which makes it more clear. injection_polarizations returned by inject_signal actually is frequency domain stuff, so that's why makes me confused. I do this and also get the strain data: signal_L1 = ifos[0].time_domain_strain

Best, Weichangfeng Guo

发件人：Gregory Ashton gitlab@git.ligo.org 发送日期：2020-09-25 03:18:16 收件人：201921160007@mail.bnu.edu.cn 主题：Re: Service Desk (from 201921160007@mail.bnu.edu.cn): suspected error report (#529) GitLabAh, I think I see what is happening now that I look at this again. The inject_signal method returns the injection_polarizations, this simply the generated waveform (which is identical between detectors), not the detector response which is performed here. Does that make sense?

— Unsubscribe

bilby-bot commented 4 years ago

In GitLab by @git.ligo:gregory.ashton on Sep 28, 2020, 16:09

Okay great, thanks Weichangfeng Guo. I'll close this issue as it seems the issue is resolved.