search

bilby-dev / bilby

A unified framework for stochastic sampling packages and gravitational-wave inference in Python.
https://bilby-dev.github.io/bilby/
MIT License
60 stars 71 forks source link

GW190425 example fails due to a relative binning error #830

Closed mj-will closed 1 hour ago

mj-will commented 1 month ago

The GW190425 example currently fails with the following error that is related to relative binning:

Traceback (most recent call last):
  File "/home/mjwill/git_repos/bilby/examples/gw_examples/data_examples/GW190425.py", line 118, in <module>
    likelihood = bilby.gw.likelihood.RelativeBinningGravitationalWaveTransient(
  File "/home/mjwill/git_repos/bilby/bilby/gw/likelihood/relative.py", line 148, in __init__
    self.compute_summary_data()
  File "/home/mjwill/git_repos/bilby/bilby/gw/likelihood/relative.py", line 334, in compute_summary_data
    stop = masked_frequency_array[end_idx]
IndexError: index 62977 is out of bounds for axis 0 with size 62977

I suspect this means there's a bug in the relative binning likelihood.

mj-will commented 1 month ago

I've checked, and this example still ran in v2.2.2, so I believe this bug was introduced in https://github.com/bilby-dev/bilby/commit/103a5127b3f896e924fd77e3bbcbbc9b404fb9ca#diff-b8983bc349cc3e1bc4986b6de834bf9493ef07528d022f86510032dce710718bR219.

@adivijaykumar do you have any insight into this?

ColmTalbot commented 1 month ago

Is this addressed by #48?

mj-will commented 1 month ago

Is this addressed by #48?

Ah, I'd missed that. I think it is.

mj-will commented 1 hour ago

Closing this since #48 has been merged.