bilde2910 / Hauk

Open-source realtime location sharing
Apache License 2.0
595 stars 59 forks source link

In-app webview #122

Open licaon-kter opened 4 years ago

licaon-kter commented 4 years ago

...that shows local share and/or groups.

But also locations shared with you.

And always shows your location (center/navigate) even if not sharing.

bilde2910 commented 4 years ago

What would the advantage of this be over just using the web interface?

licaon-kter commented 4 years ago

You can build upon this, eg. Have geofencing, like notification if user leaves an area or if getting closer than X m to me, etc

Basically do more, in an automated way, with the location info than just see it.

Ahem life360.com ahem :)

licaon-kter commented 4 years ago

@natrius Umm?

bilde2910 commented 4 years ago

The default map view in Android uses Google's proprietary map data. It may be feasible to add a dependency for osmdroid as an open source replacement. I'll look into it and see if I can come up with something.

licaon-kter commented 4 years ago

Why do you need "the default map view" thing?

bilde2910 commented 4 years ago

Why do you need "the default map view" thing?

The map view is a UI element that displays a map natively in the app, rather than embedding a browser window. It is meant to be used whenever apps need to show a map. The alternative, loading a browser that opens Hauk's map webpage from whatever server you are looking at a shared location on, will severely limit how deeply the app can interact with the contents of the map. Using a native map element instead is needed to e.g. show people from multiple shares simultaneously (a browser can only show one session at a time), show people from multiple different servers, as well as suggestions like geofencing or distance calculation.

maximbaz commented 4 years ago

Another reason for in-app webview might be that if you use something like osmdroid the quality would be a lot higher? I'm not sure, but have a look at the attached pictures for the comparison between OsmAnd app and Hauk's link opened in a browser.

Another reason could be that I don't want to give browser location permissions, but I do want to see myself on the map.

Also (not sure if it's possible) if the map would be interactive (e.g. I could tap on the metro and see the name of the metro line), it would be awesome.

Finally, as was already mentioned, geofencing is an interesting idea as well 👍

OsmAnd Hauk link in Firefox
map-osmand map-ff
bilde2910 commented 3 years ago

@maximbaz Those are some very good points that speak in favor of adding an in-app map to Hauk. Adding interaction support to map features is not a priority, as it probably opens a big can of worms regarding parsing different kinds of OSM tags for different structures and map features, and I don't know if this is something that osmdroid supports.

natrius commented 3 years ago

Okay, so, geofencing is a nice idea. Lets think about some nice small games that would be possible. No location-access to browser support is understandable as well.

Just to be clear, OSMand do create their own tiles, thats why they don't look like the official mapnik render thats used when opening it in the browser. They are created every month and need quite some resources as far as i know. And to be honest, i would not suggest doing that until your usercount rises and you are creating a heavy load on the official OSM server.

For the interactive thing: Well, just no. Its a location share and while this may be nice sometimes it should not be in a simple "show my dot and the dot of my friends on a map"-app. If you want something like that, you can use osmand and it should be faster as they have the data on the map you downloaded already. You would have to figure out quite some stuff with the tags used for multiple stuff in different countries, as like, they SHOULD be the same everywhere, but, well, who know. Using the online-data you would have to use Overpass or something like that, i guess and that would create a bigger load on the OSM-Servers as well when your user-count increases.

This App is "show my dot and the dot of my friends on a map"-app and it is really, really simple and thats why i love it. There are multiple-location-tracking-apps with server-connection that can or maybe could fulfill quite some of the other requirements. So, while i think an in-app view might be usefull (i removed my thumbs-down on the first post), i don't think other stuff is that usefull or easy to achieve. (+ the "easy and simple" part of the app will get lost imho).

If you have questions about OSM in specific, feel free to ask, i can try to answer them at least :)