search

bildpunkt / surfbird

A Microblogging client built on Electron and Vue
MIT License
331 stars 56 forks source link

Profile Creation Dialogue #55

Closed pixeldesu closed 6 years ago

pixeldesu commented 6 years ago

As we already have a column creation dialogue, we now also need a profile creation dialogue! There's not too much it needs, the only thing that gets passed to the constructor is the name the profile should get.

The Column creation dialogue can can be used as a reference for a possible integration.

What's to be done

thepriefy commented 6 years ago

2017-12-01 23_46_17-profile creation dialogue issue 55 surfbirdapp_surfbird

I'm trying to create a profile creation dialogue.

When I run 'npm run dev', this window popped-up. What should I do next to test my code?

I'm also created the 'Profile.vue'. Is this corrected?

2017-12-01 23_48_50-surfbird - c__users_thepriefy_webstormprojects_surfbird - _src_renderer_com 2017-12-01 23_49_13-surfbird - c__users_thepriefy_webstormprojects_surfbird - _src_renderer_com

pixeldesu commented 6 years ago

@thepriefy Nice work, that looks like a correct implementation to me!

If the filebrowser opens instead of the client, it looks like there might be an issue with the JS somewhere, is the console printing out an error before the window opens? You might want to check that out!

thepriefy commented 6 years ago

I just found this site: https://simulatedgreg.gitbooks.io/electron-vue/content/en/

And it said that "Installed vue-devtools and devtron tools for development"

Should I install 'vue-devtools' and 'devtron' before I develop the project?

ps. by the way, can I submit the file I just shown above as a PR?

pixeldesu commented 6 years ago

@thepriefy No, it means these tools are both installed with the application and should show up in the inspector window (as far as I know there sometimes are race conditions that cause it not to show up, but that's a rather complicated issue)

Thank you for the PR, I'll review it now and leave some feedback on it!