fix(columns): Added ids to columns

bildpunkt / surfbird

A Microblogging client built on Electron and Vue

MIT License

331 stars 56 forks source link

fix(columns): Added ids to columns #78

Open Fubinator opened 6 years ago

Fubinator commented 6 years ago

I've added ids to columns to handle them better. Originally this PR was just meant to be a refactoring, so I can begin working on #76, but this also fixes #71

Description

Every column has a unique ID from now on and every profile has an array of column-IDs. Having IDs makes it easier to change the order of profiles.

Requirements

[x] Followed code style

pixeldesu commented 6 years ago

Okay, as I finally have time again now, some feedback:

It looks like UPDATE_POST_IN_COLUMN is not working as of now.
In the Vue devtools, the columns state is always just empty arrays (It adds posts to the columns but I'm confused as to where it adds them if they are not shown)

Except for those two things, this seems solid so far, nice work!