search

bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
863 stars 63 forks source link

xfce weather applet #232

Open bilelmoussaoui opened 7 years ago

bilelmoussaoui commented 7 years ago

The icons are stored on /usr/share/xfce4/weather/icons/ with 3 different themes

and 3 different sizes : 22, 48 & 128. Only 22 will be used for tray icons. Icon names

bilelmoussaoui commented 7 years ago

@Foggalong @wa4557 @varlesh Do you guys think it's better to create a theme for xfce weather applet by the theme creator as the applet provide a theme changer or should i add it to hardcode-tray support?

varlesh commented 7 years ago

On numix and papirus already available weather icons for panel. Maybe better use this names?

varlesh commented 7 years ago

For example:

weather-few-clouds-night
weather-few-clouds
weather-fog
weather-freezing-rain
weather-hail
weather-many-clouds
weather-mist
...
bilelmoussaoui commented 7 years ago

I know, but i can't change 48 and 256 sizes! it's not what hardcode-tray should do.. can't neither change the three themes

varlesh commented 7 years ago

why 48? weather-* icons available for panel 22 and 24 px's

bilelmoussaoui commented 7 years ago

48 and 256 sizes are shown when you click on the panel, are shown here http://goodies.xfce.org/_media/projects/panel-plugins/weather-plugin-summary-forecast-rows.png?cache=

varlesh commented 7 years ago

But, you say for panel use only 22px. Numix files:

Numix/22/weather/weather-clear-night.svg
Numix/22/weather/weather-clear.svg
Numix/22/weather/weather-clouds-night.svg
Numix/22/weather/weather-clouds.svg
Numix/22/weather/weather-few-clouds-night.svg
Numix/22/weather/weather-few-clouds.svg
Numix/22/weather/weather-fog.svg
Numix/22/weather/weather-freezing-rain.svg
Numix/22/weather/weather-hail.svg
Numix/22/weather/weather-none-available.svg
Numix/22/weather/weather-overcast.svg
Numix/22/weather/weather-severe-alert.svg
Numix/22/weather/weather-showers-scattered.svg
Numix/22/weather/weather-showers.svg
Numix/22/weather/weather-snow-rain.svg
Numix/22/weather/weather-snow-scattered.svg
Numix/22/weather/weather-snow.svg
Numix/22/weather/weather-storm.svg
Numix/22/weather/weather-windy.svg
varlesh commented 7 years ago

We fix hardcoded tray icons, 48px and 256px - it's not tray icons!

varlesh commented 7 years ago

Papirus now not have weather-* icons for other sizes, available only for panel 22 and 24px and symbolic

bilelmoussaoui commented 7 years ago

@varlesh the other sizes are needed too (must be colored), they're used for Gnome Weather

varlesh commented 7 years ago

Gnome Weather used not symbolic icon?

bilelmoussaoui commented 7 years ago

On GNOME shell search? No, they never did

bilelmoussaoui commented 7 years ago

@wa4557 do you have any idea?

andia89 commented 7 years ago

I think I don't get it. There are 22px icons used in the tray which can easily be changed, right? Then there are also icons for larger sizes which are not used in the tray. Just don't change them, they are not tray icons after all

bilelmoussaoui commented 7 years ago

The issue is that xfce weather applet offers a way to change the current theme of it(small and larger sizes..).

Le 9 déc. 2016 5:43 PM, "Andreas Angerer" notifications@github.com a écrit :

I think I don't get it. There are 22px icons used in the tray which can easily be changed, right? Then there are also icons for larger sizes which are not used in the tray. Just don't change them, they are not tray icons after all

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bil-elmoussaoui/Hardcode-Tray/issues/232#issuecomment-266060867, or mute the thread https://github.com/notifications/unsubscribe-auth/AHTlxeHP30shHXlC3-txrUMA7hi6bX3_ks5rGYVMgaJpZM4LA2Hu .

varlesh commented 7 years ago

@bil-elmoussaoui if you not like xfce weather applet, you can use another app. For example Gis-weather: https://github.com/RingOV/gis-weather

varlesh commented 7 years ago

Yes. this app use hardcoded icons too, but SVG's

varlesh commented 7 years ago

also i'm open this issue: https://github.com/RingOV/gis-weather/issues/26

bilelmoussaoui commented 7 years ago

@varlesh it's not that i like it or not; i don't even use XFCE lol. I just want to fix as much hardcoded tray icons as i can ;)