Single standard for icon names

[varlesh]

I think need rewrite icon names for electron apps (and others), who contained dark/light version for tray... Also will bee good use single suffix for name. For example:

• APP-panel
• APP-panel-inactive
• APP-panel-attention
• and etc...

Some apps have suffix -panel other -tray. Also -panel suffix will be use by default, because some apps apply this icons for tray only, for example qbittorrent-panel, vlc-panel also this standard for ubuntu-mono icon theme

[bilelmoussaoui]

I will follow that ;) And open a PR on Numix icon theme too ;) Thanks for pointing that out !

[varlesh]

@bil-elmoussaoui yes, we need ask about that main developer on Numix Project

[bilelmoussaoui]

@Foggalong is quite busy those days. @palob @wa4557 what do you think about the naming convention of the hardcoded icons?

[varlesh]

For example, form papirus (-tray suffix):

discord-tray-notification.svg
discord-tray.svg
google-chrome-tray.svg
gpmdp-tray-light.svg
gpmdp-tray-pause-light.svg
gpmdp-tray-play-light.svg
guake-tray.png.svg
guake-tray.svg
harmony-tray.svg
nylas-tray-empty.svg
nylas-tray-full-newitems.svg
nylas-tray-full.svg
pamac-tray-no-update.svg
pamac-tray-update.svg
stremio-tray.svg
wechat-tray-unread-white.svg
wechat-tray-white.svg
whatsapp-tray.svg
whatsie-tray-attention.svg
whatsie-tray.svg
wire-tray-attention.svg
wire-tray.svg

But other icons have -panel suffix also need check light/dark

[varlesh]

Example new icon names:

discord-tray-notification   discord-panel-attention
discord-tray                discord-panel
google-chrome-tray          google-chrome-panel
gpmdp-tray-light            gpmdp-panel
gpmdp-tray-pause-light      gpmdp-panel-pause
gpmdp-tray-play-light       gpmdp-panel-play
guake-tray                  guake-panel
harmony-tray                harmony-panel
nylas-tray-empty            nylas-panel-inactive
nylas-tray-full-newitems    nylas-panel-attention
nylas-tray-full             nylas-panel
pamac-tray-no-update        pamac-panel
pamac-tray-update           pamac-panel-attention
stremio-tray                stremio-panel
wechat-tray-unread-white    wechat-panel-attention
wechat-tray-white           wechat-panel
whatsapp-tray               whatsapp-panel
whatsie-tray-attention      whatsie-panel-attention
whatsie-tray                whatsie-panel
wire-tray-attention         wire-panel-attention
wire-tray                   wire-panel

[varlesh]

Light:

cryptfolder-closed-light.svg
cryptfolder-indicator-light.svg
cryptfolder-open-light.svg
fluxgui-light.svg
google-tasks-indicator-light-normal.svg
google-tasks-indicator-light-starred.svg
gpmdp-tray-light.svg
gpmdp-tray-pause-light.svg
gpmdp-tray-play-light.svg
hexchat-highlight.svg
ic_light_enpass.svg
pomodoro-indicator-light-00.svg
pomodoro-indicator-light-01.svg
pomodoro-indicator-light-02.svg
pomodoro-indicator-light-03.svg
pomodoro-indicator-light-04.svg
pomodoro-indicator-light-05.svg
pomodoro-indicator-light-06.svg
pomodoro-indicator-light-07.svg
pomodoro-indicator-light-08.svg
pomodoro-indicator-light-09.svg
pomodoro-indicator-light-10.svg
pomodoro-indicator-light-11.svg
pomodoro-indicator-light-12.svg
pomodoro-indicator-light-13.svg
pomodoro-indicator-light-14.svg
pomodoro-indicator-light-15.svg
pomodoro-indicator-light-16.svg
pomodoro-indicator-light-17.svg
pomodoro-indicator-light-18.svg
pomodoro-indicator-light-19.svg
pomodoro-indicator-light-20.svg
pomodoro-indicator-light-21.svg
pomodoro-indicator-light-22.svg
pomodoro-indicator-light-23.svg
pomodoro-indicator-light-24.svg
pomodoro-indicator-light-25.svg
pomodoro-indicator-light-26.svg
pomodoro-indicator-light-27.svg
pomodoro-indicator-light-28.svg
pomodoro-indicator-light-29.svg
pomodoro-indicator-light-30.svg
pomodoro-indicator-light-31.svg
pomodoro-indicator-light-32.svg
pomodoro-indicator-light-33.svg
pomodoro-indicator-light-34.svg
pomodoro-indicator-light-35.svg
pomodoro-indicator-light-36.svg
pomodoro-indicator-light-37.svg
pomodoro-indicator-light-38.svg
pomodoro-indicator-light-39.svg
pomodoro-indicator-light-40.svg
pomodoro-indicator-light-41.svg
pomodoro-indicator-light-42.svg
pomodoro-indicator-light-43.svg
pomodoro-indicator-light-44.svg
pomodoro-indicator-light-45.svg
pomodoro-indicator-light-46.svg
pomodoro-indicator-light-47.svg
pomodoro-indicator-light-48.svg
pomodoro-indicator-light-49.svg
pomodoro-indicator-light-50.svg
pomodoro-indicator-light-51.svg
pomodoro-indicator-light-52.svg
pomodoro-indicator-light-53.svg
pomodoro-indicator-light-54.svg
pomodoro-indicator-light-55.svg
pomodoro-indicator-light-56.svg
pomodoro-indicator-light-57.svg
pomodoro-indicator-light-58.svg
pomodoro-indicator-light-59.svg
pomodoro-indicator-light-60.svg
pomodoro-indicator-light-61.svg
pomodoro-start-light.svg
pomodoro-stop-light.svg
pushbullet-indicator-light.svg
pushbullet-indicator-sync0-light.svg
pushbullet-indicator-sync1-light.svg
pushbullet-indicator-sync2-light.svg
pushbullet-indicator-sync3-light.svg
slack-indicator-highlight.svg
touchpad-indicator-light-disabled.svg
touchpad-indicator-light-enabled.svg
touchpad-indicator-light.svg
youtube-indicator-downloading-light.svg
youtube-indicator-light-disabled.svg
youtube-indicator-light.svg
youtube-indicator-light-sync0.svg
youtube-indicator-light-sync1.svg
youtube-indicator-light-sync2.svg
youtube-indicator-light-sync3.svg
youtube-indicator-light-sync4.svg
youtube-indicator-light-sync5.svg
youtube-indicator-light-sync6.svg
youtube-indicator-light-sync7.svg
youtube-indicator-light-sync8.svg
youtube-indicator-light-sync9.svg

[varlesh]

@bil-elmoussaoui i think better rewrite only electron apps with dark/black or light/white suffix icon names

[varlesh]

this have only gpmdp and need delete dark/light suffix:

{
    "name": "Google Play Music Desktop Player",
    "app_path": [
        "/usr/share/google-play-music-desktop-player/"
    ],
    "icons_path": [
        "/usr/share/google-play-music-desktop-player/resources/"
    ],
    "is_qt": false,
    "script": "electron",
    "binary": "app.asar",
    "is_script": true,
    "backup_ignore": false,
    "force_create_folder": false,
    "exec_path_script": false,
    "icons": {
        "normal-light": {
            "original": "build/assets/img/main_tray_white_s.png",
            "theme": "gpmdp-tray"
        },
        "play-light": {
            "original": "build/assets/img/playing/main_tray_white_s.png",
            "theme": "gpmdp-tray-play"
        },
        "pause-light": {
            "original": "build/assets/img/paused/main_tray_white_s.png",
            "theme": "gpmdp-tray-pause"
        },
        "normal-dark": {
            "original": "build/assets/img/main_tray_black_s.png",
            "theme": "gpmdp-tray"
        },
        "play-dark": {
            "original": "build/assets/img/playing/main_tray_black_s.png",
            "theme": "gpmdp-tray-play"
        },
        "pause-dark": {
            "original": "build/assets/img/paused/main_tray_black_s.png",
            "theme": "gpmdp-tray-pause"
        }
    }
}

[palob]

This is for icons which don't get applied without further ado anyway (due to their hardcodedness), right?

[bilelmoussaoui]

@palob exactly

[bilelmoussaoui]

So I'm going to go with -tray for icons and use app-tray-status or app-tray-attention for notification. Before, I will commit the changes, and I won't release a new version until this is completely done on the icon themes side too!

[varlesh]

i'm close this issue, because all worked - it's main! And i don't want rewrite icon names - that very long work and tiresome