Big chrome icon

[Feichtmeier]

Specifications

• Hardcode-Tray version : 3.8.2
• Distribution : Ubuntu 16.04
• Gtk version : 3.20
• Inkscape version : 0.9.1 if installed
• Cairo version : `` if installed
• Sni-qt version: `no idea how to check this but I installed it from your repo
• Application name : google-chrome
• Application version : 59.0.3071.86

Expected behavior and actual behavior

I would expect the icon to have the same size as other icons that have been successfully converted by hardcode-tray like telegram and dropbox but instead the icon size is much bigger - about 30% bigger (sea the screenshot)

Steps to reproduce the problem

1. install GNOME 3.20, chrome, hardcode-tray
2. hardcode-tray -ct Inkscape
3. see big chrome icon

[bilelmoussaoui]

Can you paste the content of the log file that can be found in /tmp/Hardcode-Tray/. The log files are ordered by date/time

[Feichtmeier]

There is no Hardcode-Tray folder in tmp :O

[bilelmoussaoui]

@Feichtmeier Can you try running the script again and see what happen? you might have restarted your laptop since the last time you've used Hardcode-Tray. The files on /tmp folder are removed automatically whenever you restart your system. Also, the output on the terminal would be great too. Try running something like hardcode-tray --apply -ct Inkscape --only google-chrome

[Feichtmeier]

hardcode-tray --apply -ct Inkscape --only google-chrome
[sudo] password for mememe: 
Welcome to Hardcode-Tray!
Desktop Environment: Gnome
Scaling Factor: 2
Icon Size: 44
Icon Theme: Pop
Conversion Tool: Inkscape
To Do: Google-Chrome
Applying now..

Google Chrome       [####################################] 1/1 100.0% 2.76s
Took 2.76s to finish the tasks

Logfile which is now there (sorry):

[DEBUG] 2017-06-09 16:07:05 DE: Gnome
[DEBUG] 2017-06-09 16:07:05 Scaling Factor/GNOME: 2
[DEBUG] 2017-06-09 16:07:05 Arguments/Icon Size: None
[DEBUG] 2017-06-09 16:07:05 Config file: Not found.
[DEBUG] 2017-06-09 16:07:05 System/Icon Size: 22
[DEBUG] 2017-06-09 16:07:05 Icon Size: 44
[DEBUG] 2017-06-09 16:07:05 System/Theme/GSettings: Pop
[DEBUG] 2017-06-09 16:07:05 Arguments/Conversion Tool: Inkscape
[DEBUG] 2017-06-09 16:07:05 Arguments/Only: google-chrome
[DEBUG] 2017-06-09 16:07:05 Config/Backup Ignore: False
[DEBUG] 2017-06-09 16:07:05 Create new backup folder for Google Chrome
[DEBUG] 2017-06-09 16:07:05 Creating directory: /home/frederik/.config/Hardcode-Tray/Google Chrome/09-06$
[DEBUG] 2017-06-09 16:07:05 Executing command: inkscape -z -f /usr/share/icons/Pop/22x22@2x/panel/google$
[ERROR] 2017-06-09 16:07:07 Couldn't find a PNG file.
[DEBUG] 2017-06-09 16:07:07 Executing command: inkscape -z -f /usr/share/icons/Pop/22x22@2x/panel/google$
[DEBUG] 2017-06-09 16:07:08 Backup file: /tmp/10153 to: /home/frederik/.config/Hardcode-Tray/Google Chro$
[DEBUG] 2017-06-09 16:07:08 Executing command: chmod 0777 /home/frederik/.config/Hardcode-Tray/Google Ch$

Done, Thank you for using the Hardcode-Tray fixer!

[bilelmoussaoui]

The icon looks huge due to the scaling factor. It's set to 2 in your system and so the icon is multiplied by 2. As you can see the icon size is set to 44. You can try by forcing the --size 16 and see what happens :)

[Feichtmeier]

It became indeed smaller! But when I apply it to all without the "--only " parameter will all icons become smaller? since telegram and insync and dropbox look fine. Now only the GPMDP looks big

[bilelmoussaoui]

Well, this part of the issue isn't a Hardcode-Tray issue :P Because either we support Scaling factor which is buggy or remove it and in this case the icons will look pretty small on a HiDPI screen! Do you have any suggestion on how we should with this specific case?

• Hardcode-Tray only rescale the tray icon when they're converted to png; So if GPMDP uses SVG icons, they won't be scaled up but we will let Gtk handles that part (in your case with Gnome)

[varlesh]

I think it's bug HiDPI libappindicator, he don't have scale for SVG's. Papirus have only vector icons and 44px should bee rendered fine... Similar bug https://github.com/Bajoja/indicator-kdeconnect/issues/53

[bilelmoussaoui]

@varlesh Thanks for the feedback! Anyway, i wasn't going to modify anything as Scaling factor is detected correctly from Hardcode-Tray side...

[bilelmoussaoui]

At worst, you can change the value of scaling factor to 1 again. And set whatever icon size you want. For now, the icon size must be one of the following values 16, 22, 24. But you can change it pretty easily by modifying this file https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/src/const.py#L42 and adding another icon size for example 32 or 48... And use hardcode-tray --size MYNEWSIZE

I can't do more about this, as it's out of the purpose of Hardcode-Tray. If you think that the way the scaling factor works should be reworked please reopen the issue :)