search

bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
863 stars 61 forks source link

Add gnome-xorg to the DE list #594

Closed terencode closed 5 years ago

terencode commented 5 years ago

$DESKTOP_SESSION can report gnome as gnome-xorg

bilelmoussaoui commented 5 years ago

I would just make detect_de fallback to gnome if it's gnome-xorg instead of this change

terencode commented 5 years ago

Done.

bilelmoussaoui commented 5 years ago

Thanks!

terencode commented 5 years ago

you're welcome! :+1:

terencode commented 5 years ago

I incorrectly read your code and this addition is in fact not needed because you query both DESKTOP_SESSION and XDG_CURRENT_DESKTOP, which the latter returns just 'gnome' even on Xorg. This thus needs a revert.

bilelmoussaoui commented 5 years ago

Oh, I should have remembered what I wrote a few years ago.

terencode commented 5 years ago

Ahah :stuck_out_tongue: What made me think it was not working is I forgot to run sudo with -E so it couldn't read the ENV...

terencode commented 5 years ago

Just a reminder you probably want to revert this.

bilelmoussaoui commented 5 years ago

I actually don't have the time to work on this anymore since a long time now. It doesn't hurt to keep it around for now. CC @varlesh in case you have some free time & want to revert this