bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
863 stars 63 forks source link

Cadence #665

Closed rauldipeas closed 3 years ago

rauldipeas commented 3 years ago

How could I fix this? image

varlesh commented 3 years ago

I think it's possible fixed with -panel suffix: https://github.com/falkTX/Cadence/blob/master/src/systray.py#L100

rauldipeas commented 3 years ago

@falkTX can You implement this?

varlesh commented 3 years ago

@rauldipeas it's already implemented. All libappindicator-apps used for tray icon -panelsuffix. Try make symlink cadence-panel to any monochrome icon for test.

rauldipeas commented 3 years ago

@rauldipeas it's already implemented. All libappindicator-apps used for tray icon -panelsuffix. Try make symlink cadence-panel to any monochrome icon for test.

I made symlinks on all panel folders, don't work.

varlesh commented 3 years ago

clear icon cache and try env DESKTOP_SESSION=ubuntu cadence

rauldipeas commented 3 years ago

Same results... :/ image

varlesh commented 3 years ago

need run with AppIndicator engine... maybe need set another environment options

rauldipeas commented 3 years ago

I'm using classic systray on XFCE.

varlesh commented 3 years ago

i'm add tray icons for experiments... try another env options: https://github.com/falkTX/Cadence/blob/master/src/systray.py#L32-L38

varlesh commented 3 years ago

Another solution - added fallback icon (with fix icon size) for Qt engine:

# Get Icon from user theme, using our own as backup (Oxygen)
def getIcon(icon, size=22):
    return QIcon.fromTheme("cadence-panel", icon, QIcon(":/%ix%i/%s.png" % (size, size, icon)))
varlesh commented 3 years ago

https://github.com/falkTX/Cadence/blob/master/src/systray.py#L67-L69

rauldipeas commented 3 years ago

Another solution - added fallback icon (with fix icon size) for Qt engine:

# Get Icon from user theme, using our own as backup (Oxygen)
def getIcon(icon, size=22):
    return QIcon.fromTheme("cadence-panel", icon, QIcon(":/%ix%i/%s.png" % (size, size, icon)))

I'm sorry, i don't know how to do this...

varlesh commented 3 years ago

I'm sorry, i don't know how to do this...

i'm already write this: Find this on systray.py:

# Get Icon from user theme, using our own as backup (Oxygen)
def getIcon(icon, size=16):
    return QIcon.fromTheme(icon, QIcon(":/%ix%i/%s.png" % (size, size, icon)))

and replace:

# Get Icon from user theme, using our own as backup (Oxygen)
def getIcon(icon, size=22):
    return QIcon.fromTheme("cadence-panel", icon, QIcon(":/%ix%i/%s.png" % (size, size, icon)))
rauldipeas commented 3 years ago

I had to do like this to work...

# Get Icon from user theme, using our own as backup (Oxygen)
def getIcon(icon, size=24):
    return QIcon.fromTheme("cadence-panel", QIcon(":/%ix%i/%s.png" % (size, size, icon)))
varlesh commented 3 years ago

ok... it's not hardcode-tray issue. We not change app icons for launchers