search

bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
863 stars 63 forks source link

GDLauncher not being detected #669

Open Remyrios opened 3 years ago

Remyrios commented 3 years ago

Specifications

Expected behavior and actual behavior

The script should detect GDLauncher (As it is in the database) and replace the icon. Instead, it just doesn't detect it at all, tried with gdlauncher-appimage and gdlauncher-bin package from the AUR. The icon pack used is Papirus. Tried with the --only and --path arguments, still didn't work.

Steps to reproduce the problem

  1. Install hardcode-tray-git from the AUR
  2. Install gdlauncher-bin from the AUR
  3. Run sudo -E hardcode-tray --conversion-tool RSVGConvert --size 22 --theme Papirus
varlesh commented 3 years ago

it's strange, because tray icon not changed on sources:

  const RESOURCE_DIR = isDev ? __dirname : path.join(__dirname, '../build');

  const iconPath = path.join(RESOURCE_DIR, 'logo_32x32.png');

  const nimage = nativeImage.createFromPath(iconPath);

  tray = new Tray(nimage);

https://github.com/bilelmoussaoui/Hardcode-Tray/blob/master/data/database/gdlauncher.electron.json Also all this paths added to database: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gdlauncher-appimage#n36 https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gdlauncher-bin#n32