search

bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
863 stars 63 forks source link

Versions RegExp VARIABLE for Discord #671

Closed varlesh closed 3 years ago

varlesh commented 3 years ago

Discord have 3 versions:

and etc...

and etc...

varlesh commented 3 years ago

@BlueManCZ @SmartFinn @rauldipeas

varlesh commented 3 years ago

I don't know Python and can offer some not good variants:

  1. Drop Canary & PTB versions. Only Stable - that not updated very often.
  2. Write in config futured not published release - guess method... It's @SmartFinn idea, but don't like me, but as easy solution for this If anybody have idea, please WELCOME
rauldipeas commented 3 years ago

Drop Canary & PTB, it's not the goal, i think.

varlesh commented 3 years ago

@rauldipeas But this versions updated every week. You want update config every week?

varlesh commented 3 years ago

Oh! I found 4 version: https://aur.archlinux.org/cgit/aur.git/log/?h=discord-development Guys, it's madness !!!

rauldipeas commented 3 years ago

I think that if this need a regular updates on scripts, it's a worthless job, there's no point to maintain.

varlesh commented 3 years ago

Yes it's need a regular update on scripts and regular start hardcode-tray (but it's can be solved with cron)

varlesh commented 3 years ago

I'm update config for example and info

rauldipeas commented 3 years ago

Maybe you should add support to run hardcode-tray --apply --only $APP when app package was updated.

varlesh commented 3 years ago

This already implemented: sudo -E hardcode-tray -ct RSVGConvert --apply --only discord.electron

rauldipeas commented 3 years ago

I meant discord package.

varlesh commented 3 years ago

@rauldipeas You mean GitHub action + parser. Where you found tags releases?

rauldipeas commented 3 years ago

@varlesh I mean an apt rule on hardcode-tray package, that run script when certain packages(on hardcode-tray database) are updated.

SmartFinn commented 3 years ago

@rauldipeas what about other distros? Even not every package manager has post-run scripts.

rauldipeas commented 3 years ago

@SmartFinn i can't figure out a implementation for another distros, but on apt it's possible.

varlesh commented 3 years ago

@rauldipeas It's not solution. Hardcode-tray used on other distros too...

rauldipeas commented 3 years ago

I don't think it is...

It's just an idea.

varlesh commented 3 years ago

Ok guys... We think (@SmartFinn & @varlesh ) and decided

  1. Discord have 4 versions - it's hard to track
  2. Anyway if all config actual you need constant updating and every run hardcode-tray... again & again It's vicious circle and senselessly I'm drop non-Stable versions. Want themable tray icons - use stable version