Slack icon fix - Githubissues

BlueManCZ commented 3 years ago

Did Slack again change icon location or something? The current fix doesn't seem to work with Slack 4.11.3.

varlesh commented 3 years ago

please check with new updates

BlueManCZ commented 3 years ago

Okay, sorry, my bad. It worked before, I just forgot to revert before applying another fix. Now, after your update, it crashes, so please return to the previous one and you can close this.

varlesh commented 3 years ago

@BlueManCZ But you added Slack support)) I'm grep Base64 tray icons and this located on dist/slack.json LOG:

 File "/usr/bin/hardcode-tray", line 121, in <module>
    App.execute()
  File "/usr/lib/python3.8/site-packages/HardcodeTray/app.py", line 120, in execute
    delta = app.do_action(action)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/application.py", line 148, in do_action
    self.install()
  File "/usr/lib/python3.8/site-packages/HardcodeTray/decorators.py", line 58, in wrapper
    func(app)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/application.py", line 96, in install
    self.execute(Action.APPLY)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/helpers/binary.py", line 50, in execute
    self.install_icon(icon, icon_path)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/b64electron.py", line 50, in install_icon
    file_content = asar.read_file(target).decode()
AttributeError: 'NoneType' object has no attribute 'decode'
Error in sys.excepthook:
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/apport_python_hook.py", line 153, in apport_excepthook
    with os.fdopen(os.open(pr_filename,
FileNotFoundError: [Errno 2] Нет такого файла или каталога: '/var/crash/_usr_bin_hardcode-tray.0.crash'

Original exception was:
Traceback (most recent call last):
  File "/usr/bin/hardcode-tray", line 121, in <module>
    App.execute()
  File "/usr/lib/python3.8/site-packages/HardcodeTray/app.py", line 120, in execute
    delta = app.do_action(action)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/application.py", line 148, in do_action
    self.install()
  File "/usr/lib/python3.8/site-packages/HardcodeTray/decorators.py", line 58, in wrapper
    func(app)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/application.py", line 96, in install
    self.execute(Action.APPLY)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/helpers/binary.py", line 50, in execute
    self.install_icon(icon, icon_path)
  File "/usr/lib/python3.8/site-packages/HardcodeTray/modules/applications/b64electron.py", line 50, in install_icon
    file_content = asar.read_file(target).decode()
AttributeError: 'NoneType' object has no attribute 'decode'

varlesh commented 3 years ago

This extracted app.asar. You can check it slack-app-asar.tar.gz

BlueManCZ commented 3 years ago

Yes, I just wanted to say that I was wrong in this issue. It worked fine.

varlesh commented 3 years ago

It' from 4.12. You use this version?

BlueManCZ commented 3 years ago

I use 4.11.3

BlueManCZ commented 3 years ago

Did something change from 4.11.3 to 4.12?

varlesh commented 3 years ago

I'm not understand... and confused

varlesh commented 3 years ago

Earlier i'm grep icon and this located on dist/slack.json BUT NOW it's grep on dist/main.bundle.js WTF???!!!

BlueManCZ commented 3 years ago

Yes, I'm confused too now. :smile:

BlueManCZ commented 3 years ago

I don't even see slack.json in your asar.

varlesh commented 3 years ago

omg lol PLEASE excuse me. I'm grep hardcode-tray database earlier.... LOL ))) It's very funny issue

varlesh commented 3 years ago

@BlueManCZ wrong issue, wrong commit = revert all!!! LOL

BlueManCZ commented 3 years ago

Yes, this doesn't happen very often. :smile:

varlesh commented 3 years ago

@BlueManCZ You know python. Maybe you find time and drop other conversions tools... Inkscape, Imagemagic and etc... use only RSVGConvert - it's worked good for mostly Linux desktops PS: option --conversion-tool {Inkscape,CairoSVG,RSVGConvert,SVGExport,ImageMagick} causes many problems on users

varlesh commented 3 years ago

https://github.com/bilelmoussaoui/Hardcode-Tray/issues/672 https://github.com/bilelmoussaoui/Hardcode-Tray/issues/630 https://github.com/bilelmoussaoui/Hardcode-Tray/issues/578

BlueManCZ commented 3 years ago

Create a new issue for this and mention me. I will see when I get time to look into it.

varlesh commented 3 years ago

This already here: https://github.com/bilelmoussaoui/Hardcode-Tray/issues/578

varlesh commented 3 years ago

@BlueManCZ If you interest develop hardcode-tray we can request vote on @bilelmoussaoui to add you on membership))

BlueManCZ commented 3 years ago

Yes, I can collaborate with you. I'll see if I can find some time.

bilelmoussaoui / Hardcode-Tray

Slack icon fix #673