Has icon for Rambox but not for Rambox Pro

bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux

Other

861 stars 63 forks source link

Has icon for Rambox but not for Rambox Pro #699

Closed DenysMb closed 3 years ago

DenysMb commented 3 years ago

Specifications

Hardcode-Tray version : 4.3.3
Distribution : Arch Linux
Gtk version : 3.24
Application name : Rambox Pro
Application version : 1.5.2-1

Expected behavior and actual behavior

The Rambox Pro app should get the same icon as the Rambox app, but it is different.

Steps to reproduce the problem

Install Rambox and Rambox Pro.
Run the hardcode-tray script.
Run and see the different icons.

varlesh commented 3 years ago

added

DenysMb commented 3 years ago

It seems like it didn't work. I had the last version from Hardcode-Tray from Github, ran it, it shows "Rambox" when we apply but the Rambox Pro tray icon remains the same.

varlesh commented 3 years ago

What icons used? Screenshot_20210814_050800

varlesh commented 3 years ago

It's different with Rambox icons: Screenshot_20210814_051657

varlesh commented 3 years ago

active - it's normal state done.fw - ? done - ? inactive - i think it's offline mention - how draw this? unread - message warning - how draw this?

varlesh commented 3 years ago

updated on Papirus and here

DenysMb commented 3 years ago

What icons used?

The strange part is that I never saw the yellow and green icon. The only three icons that appears for me, using with WhatsApp Web, Discord, Instagram, Telegram, Zoho Mail, Gmail, Microsoft Teams, Slack and Outlook, is the "active", the "mention"/"done" and the "unread".

varlesh commented 3 years ago

i'm added almost all icons (except done.fw - it's not have ico Windows version and i don't know what is this): https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/commit/330898b9e69e18090bd62ff1349f0df9b3996ab0

varlesh commented 3 years ago

you can test and close, if all fine

DenysMb commented 3 years ago

This error is because of something in some recent commit?

varlesh commented 3 years ago

Sorry, i'm not attentive. Updated

varlesh commented 3 years ago

@DenysMb worked?

DenysMb commented 3 years ago

@varlesh sorry for the delay. I am afraid that is not working. It's really weird. The script now don't show an error and, in theory, updates the Rambox Pro icon but the icon remains the same. I deleted the cache, I deleted Rambox Pro, deleted the /opt/ramboxpro folder, reinstalled the app, ran the script and the icon remains the same old icon ):

DenysMb commented 3 years ago

It creates the folder /home/USER/.config/Hardcode-Tray/Rambox Pro/DATE/ and these are the icons inside:

I'd installed the Rambox Pro version from AUR: https://aur.archlinux.org/packages/rambox-pro-bin/

varlesh commented 3 years ago

Maybe they used icons from Windows directory? Try change all paths: sudo sed -i s/linux/win/g /usr/share/hardcode-tray/database/rambox-pro.electron.json And restart again

DenysMb commented 3 years ago

Deleted my last comment because I forgot to "re-apply". Now it's work. Thank you!

varlesh commented 3 years ago

ok, i'm added win paths

DenysMb commented 3 years ago

Hi, @varlesh. One thing: the icon for for mention or done.fw (probably this second one) is missing: The other stats are working normally.

varlesh commented 3 years ago

added as mention icon