bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
861 stars 63 forks source link

Bitwarden not detected #722

Open drikqlis opened 2 years ago

drikqlis commented 2 years ago

Specifications

Expected behavior and actual behavior

The application is not detected at all:

Welcome to Hardcode-Tray!
Hardcode-Tray replaces some icons on the binary files of some applications. 
Please close all the running applications before running Hardcode-Tray script.
Desktop Environment: Kde
Scaling Factor: 1
Icon Size: 22
Icon Theme: Papirus-Dark
Conversion Tool: RSVGConvert
To Do: All
1 - Apply
2 - Revert
3 - Clear Backup Cache
Please choose: 1
Applying now..

Chromium            [#####...............................] 1/7 14.3% 0.02s
HP Printer          [##########..........................] 2/7 28.6% 0.02s
Mumble              [#####################...............] 4/7 57.1% 0.00s
Signal              [##########################..........] 5/7 71.4% 8.61s
Steam               [###############################.....] 6/7 85.7% 0.75s
Teamviewer          [####################################] 7/7 100.0% 0.00s
Took 9.39s to finish the tasks

Done, Thank you for using the Hardcode-Tray fixer!

Maybe it has to do with app.asar not being unpacked? I do not see the resource folder in /usr/lib/bitwarden/, only app.asar and package.json. I unpacked it but it was still not detected. I tried on normal and git version of hardcode-tray from AUR.

Steps to reproduce the problem

  1. Install bitwarden on Arch-Linux from official repo: sudo pacman -S bitwarden
  2. Install hardcode-tray or hardcode-tray-git from AUR.
  3. Run hardcode-tray
  4. Application not detected, tray not changed.
varlesh commented 2 years ago

used black icon or white on new version?

drikqlis commented 2 years ago

I use Papirus-Dark so the icons are white if it matters (bitwarden-tray.svg). Bitwarden is unchanged blue, didn't seem to register with hardcode-tray at all.

varlesh commented 2 years ago

It's strange, i'm extract arch-package and app.asar too and icons paths/names not changed: image On database:

{
    "name": "Bitwarden",
    "app_path": [
        "/opt/Bitwarden/",
        "/usr/lib/bitwarden/",
        "/var/lib/flatpak/app/com.bitwarden.desktop/"
    ],
    "icons_path": [
        "/opt/Bitwarden/resources/",
        "/usr/lib/bitwarden/resources/",
        "/var/lib/flatpak/app/com.bitwarden.desktop/current/active/files/Bitwarden/resources/"
    ],
    "binary": "app.asar",
    "script": "electron",
    "icons": {
        "tray": {
            "original": "images/icon.png",
            "theme": "bitwarden-tray"
        }
    }
}
yochananmarqos commented 1 year ago

I've been doing this in my hardcode-tray-git AUR package, it works.

  # Correct app.asar path for community bitwarden package
  sed -i 's|/usr/lib/bitwarden/resources/|/usr/lib/bitwarden/|g' \
    data/database/bitwarden.electron.json