bilelmoussaoui / Hardcode-Tray

Fixes Hardcoded tray icons in Linux
Other
859 stars 63 forks source link

Slack icons are left untouched, theme does not apply #754

Open gianco opened 1 year ago

gianco commented 1 year ago

Specifications

Expected behavior and actual behavior

Running

sudo -E hardcode-tray --conversion-tool RSVGConvert --size 22 --theme Papirus-Dark --only slack

should apply the Papirus-Dark icons for slack, but icons are left untouched

Steps to reproduce the problem

  1. Install Slack 4.29.149
  2. Run the above command
  3. The tray icons does not change
keighrim commented 1 year ago

It looks like they changed the icon paths?

ls -la /usr/lib/slack/resources/app.asar.unpacked/dist/resources/
total 136
drwxr-xr-x 3 root root  4096 Feb  9 08:03 .
drwxr-xr-x 3 root root  4096 Feb  9 07:56 ..
-rw-rw-r-- 1 root root 40508 Feb  9 08:02 app-beta.ico
-rw-rw-r-- 1 root root 44335 Feb  9 08:02 app-release.ico
drwxr-xr-x 3 root root  4096 Feb  9 08:02 extensions
-rw-rw-r-- 1 root root 11510 Feb  9 08:02 slack-taskbar-highlight.ico
-rw-rw-r-- 1 root root 11510 Feb  6 15:59 slack-taskbar-rest.ico
-rw-rw-r-- 1 root root 11510 Feb  9 08:02 slack-taskbar-unread.ico

(for reference to beta https://github.com/bilelmoussaoui/Hardcode-Tray/blob/beta/data/database/slack.json)

I'm on arch, installed slack-desktop via AUR.

jherrman commented 1 year ago

Can confirm this issue also occurs on Fedora 36 with Gnome 42 and Slack 4.29.149, installed via RPM.