search

bilelmoussaoui / ashpd

A Rust wrapper around XDG portals DBus interfaces
https://bilelmoussaoui.github.io/ashpd/ashpd/
MIT License
242 stars 44 forks source link

color fixes 0.8 #198

Closed wash2 closed 8 months ago

wash2 commented 8 months ago

Should the color fixes be applied to 0.7? I guess the change to receive_accent_color_changed is breaking, so I'm not sure.

bilelmoussaoui commented 8 months ago

Should the color fixes be applied to 0.7? I guess the change to receive_accent_color_changed is breaking, so I'm not sure.

It is that is true, but the old implementation was just wrong. It would have never worked, so it is ok to break API here.

wash2 commented 8 months ago

Is failing CI blocking a merge?

bilelmoussaoui commented 8 months ago

Yes, please target 0.8 branch. I won't be updating the 0.7 version anymore.

bilelmoussaoui commented 8 months ago

Thanks a lot ! will be doing a fix release sometime in the future once more fixes are collected