search

bilelmoussaoui / ashpd

A Rust wrapper around XDG portals DBus interfaces
https://bilelmoussaoui.github.io/ashpd/ashpd/
MIT License
242 stars 44 forks source link

Misc gtk4 fixes #205

Closed hfiguiere closed 6 months ago

hfiguiere commented 6 months ago

There is no reason to require Gtk 4.14 but to prevent building on Fedora 39 (or other recent distros).

Also fix a warning: 

(ashpd-demo:1693266): Adwaita-WARNING **: 20:36:20.845: AdwNavigationPage 0x55c88967d080 is missing a title. To hide a header bar title, consider using AdwHeaderBar:show-title instead.
bilelmoussaoui commented 6 months ago

There is no reason to require Gtk 4.14 but to prevent building on Fedora 39 (or other recent distros).

I actually intentionally used v4_14 there. The app is only shipped as a flatpak so that justification is not really enough for me to merge that change.

For the second commit, the fix is wrong. A proper title must be set instead of an empty string

hfiguiere commented 6 months ago

It prevent contribution to require 4.14. Whether it's shipped as flatpak or not. as it is not necessary.

bilelmoussaoui commented 6 months ago

It prevent contribution to require 4.14. Whether it's shipped as flatpak or not. as it is not necessary.

There is a difference in the behaviour of the GStreamer plugin which is the whole reason why the feature was enabled.