search

bilelmoussaoui / ashpd

A Rust wrapper around XDG portals DBus interfaces
https://bilelmoussaoui.github.io/ashpd/ashpd/
MIT License
242 stars 44 forks source link

desktop/game_mode: Use `i32` for pid #234

Closed kjarosh closed 2 months ago

kjarosh commented 2 months ago

As per the documentation, methods which accept pids (e.g. RegisterGame, RegisterGameByPid) require the type of pid to be i (i32), not u (u32).

Using u32 causes errors in runtime, making these methods unusable. This bug was most likely introduced by ae81250.

See https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.GameMode.html

torokati44 commented 1 month ago

Do you think we could get a release on crates.io with this fix sometime soon?

bilelmoussaoui commented 1 month ago

Do you think we could get a release on crates.io with this fix sometime soon?

sure, later this week

torokati44 commented 1 month ago

Great, thanks!

torokati44 commented 1 month ago

(a polite bump on this :no_mouth: )

bilelmoussaoui commented 1 month ago

ah, sorry, completely forgot about it. let me do a release now

torokati44 commented 1 month ago

No worries, thanks a lot!

bilelmoussaoui commented 1 month ago

0.9.2 should be up

torokati44 commented 1 month ago

Awesome, that was quick! ^^