bilelmoussaoui / flatpak-vscode

Integrate Flatpak with VSCode
MIT License
91 stars 13 forks source link

Check for valid app id is missing rules #201

Open A6GibKm opened 1 year ago

A6GibKm commented 1 year ago

https://github.com/bilelmoussaoui/flatpak-vscode/blob/master/src/manifestUtils.ts#L91-L132 is

SeaDve commented 1 year ago

Not checking for numeric (0..9) characters, its only checking for a-z, A-Z, -, _.

I believe it also checks 0..9 characters through isNumber.

A6GibKm commented 1 year ago

Oh you are right, I didn't saw it.

A6GibKm commented 1 year ago

It only leaves us with the - issue, but it might not be part of the spec but an unfortunate consequence of dbus rules.