search

bilelmoussaoui / oo7

James Bond went on a new mission as a Secret Service provider
https://bilelmoussaoui.github.io/oo7/oo7/
MIT License
63 stars 12 forks source link

Allow using openssl crate for cryptographic primitives #32

Closed ueno closed 1 year ago

ueno commented 1 year ago

This allows oo7 to selectively use the openssl crate instead of the RustCrypto crates, when openssl_crypto feature is enabled. The motivation behind this is to make it FIPS 140 compliant by delegating the cryptographic primitives implementation to the FIPS-certified system library (i.e., libcrypto.so in OpenSSL).

bilelmoussaoui commented 1 year ago

Thank you for your PR, although I think we should still have an optional feature for opting-out of OpenSSL instead of dropping the current code completely

ueno commented 1 year ago

Yes, I agree (pulling in openssl may also mean a license change to ASL-2.0). Let me add a build-time feature.

ueno commented 1 year ago

@bilelmoussaoui I think the CI should pass now; could you retrigger the workflow?

bilelmoussaoui commented 1 year ago

lgtm, thanks a lot!