bilelmoussaoui / oo7

James Bond went on a new mission as a Secret Service provider
https://bilelmoussaoui.github.io/oo7/oo7/
MIT License
63 stars 12 forks source link

Use chrono::DateTime for secrets #44

Closed A6GibKm closed 10 months ago

A6GibKm commented 10 months ago

I am not sure if adding another dependency is desired.

Its somewhat weird to return the number of seconds since the unix epoch in anything but as a date.

bilelmoussaoui commented 10 months ago

I am not a fan of depending on chrono for this very small bit; using Duration is fine and people can convert it to a date using whatever library they are using

A6GibKm commented 10 months ago

Ok then ill add the methods as duration

A6GibKm commented 10 months ago

Done.