search

bilelmoussaoui / oo7

James Bond went on a new mission as a Secret Service provider
https://bilelmoussaoui.github.io/oo7/oo7/
MIT License
57 stars 11 forks source link

Add keyring-util #50

Closed A6GibKm closed 7 months ago

A6GibKm commented 8 months ago

Fixes: https://github.com/bilelmoussaoui/oo7/issues/48

A6GibKm commented 8 months ago

Regarding search and lookup, one could do get and list instead.

bilelmoussaoui commented 7 months ago

Looks good to me but still lacks CI bits :)

bilelmoussaoui commented 7 months ago

Looks good to me! I have one suggestion though and I'm not sure it's possible to implement. It would be great if keyring-util can handle a scenario like the following,

 ./target/debug/keyring-util store 'My password' key1 value1
Error: The collection 'default' doesn't exists

So, we need a new command to create a keyring or collection. What do you think @A6GibKm ?

I would check first what is the behaviour of secret-tool in this case. Collections are not widely used so maybe we should automatically create the default collection if it doesn't exists?

A6GibKm commented 7 months ago

Looks good to me! I have one suggestion though and I'm not sure it's possible to implement. It would be great if keyring-util can handle a scenario like the following,

 ./target/debug/keyring-util store 'My password' key1 value1
Error: The collection 'default' doesn't exists

So, we need a new command to create a keyring or collection. What do you think @A6GibKm ?

I would check first what is the behaviour of secret-tool in this case. Collections are not widely used so maybe we should automatically create the default collection if it doesn't exists?

For the moment I will just create one if needed.

A6GibKm commented 7 months ago

Looks good to me but still lacks CI bits :)

Could you please take care of this? I have yet to understand how github CI works. Figured it out already.