search

bilelmoussaoui / oo7

James Bond went on a new mission as a Secret Service provider
https://bilelmoussaoui.github.io/oo7/oo7/
MIT License
57 stars 11 forks source link

cli: Do not assume secrets are valid utf8 #65

Closed A6GibKm closed 5 months ago

A6GibKm commented 6 months ago

Portal secrets are random bytes, hence the cli will crash.

We should load them into a OsString and have a --hex flag to display them as hex.

sophie-h commented 6 months ago

OsString sounds wrong. On Windows, for example, an OSString has to be valid utf16, right? Binary data is just binary data.

A6GibKm commented 6 months ago

But this is a linux app which could be piped into something else

bilelmoussaoui commented 5 months ago

image i agree, this is not great (both cases)