search

bilelmoussaoui / oo7

James Bond went on a new mission as a Secret Service provider
https://bilelmoussaoui.github.io/oo7/oo7/
MIT License
57 stars 11 forks source link

portal: update create_item() to return portal::Item #68

Closed warusadura closed 5 months ago

warusadura commented 5 months ago

This change updates the oo7::portal::Keyring::create_item() to return oo7::portal::Item instead of ()

We need this change for the server side implementation. In server/daemon side we are wrapping the return value of create_item() inside a struct.

bilelmoussaoui commented 5 months ago

Lgtm

for future commits, please describe why the change is needed not what the change itself. In this case, I would have instead mentioned the use case of wrapping the portal::Item` in the server side implementation.