search

bilelmoussaoui / oo7

James Bond went on a new mission as a Secret Service provider
https://bilelmoussaoui.github.io/oo7/oo7/
MIT License
57 stars 11 forks source link

oo7::portal::Keyring::items() is no longer async anymore since 0.3 #80

Closed haecker-felix closed 2 months ago

haecker-felix commented 3 months ago

Despite being async it is currently blocking. Affected function seems to be derive_key()

image

May be related

sophie-h commented 3 months ago

I think I already mentioned before that I added the spawn_blocking for a reason and it cannot just be removed.

bilelmoussaoui commented 3 months ago

I think I already mentioned before that I added the spawn_blocking for a reason and it cannot just be removed.

I haven't received any review about it. I even pinged you on github but I do understand the overwhelming amount of notifications... so not an issue.

I rather make https://github.com/bilelmoussaoui/oo7/blob/main/client/src/portal/api/mod.rs#L247 do the spawn_blocking bit instead.