bilfeldt / laravel-http-client-logger

A logger for the Laravel HTTP Client

MIT License

144 stars 19 forks source link

Global request logging WIP #18

Open kyranb opened 2 years ago

kyranb commented 2 years ago

Hey Bilfeldt,

After your work on Footprints, I wanted to try and return the favour.

Description

This PR is a WIP. Haven't had the chance to test properly yet.

Does this close any currently open issues?

Aimes to fix #2

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update ...

Checklist

[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

bilfeldt commented 2 years ago

@kyranb Did you see me previous comment by any chance? 👍

kyranb commented 2 years ago

@bilfeldt Sorry, yes I did but I haven't had a chance to dive back into this yet. I think you're correct, we only need to log the the sent request 👍