fix: only log error when fails

[everpcpc]

and make golint happy

[codecov-commenter]

Codecov Report

Merging #131 into master will decrease coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   48.22%   48.18%   -0.04%     
==========================================
  Files          66       66              
  Lines        6522     6527       +5     
==========================================
  Hits         3145     3145              
- Misses       3024     3029       +5     
  Partials      353      353              

Impacted Files	Coverage Δ
platform/mesos/executor.go	0.00% <0.00%> (ø)
platform/mesos/scheduler.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d934a02...74bf1b8. Read the comment docs.

[wayslog]

well，make golint happy

everpcpc notifications@github.com 于2020年7月14日周二 下午12:36写道：

@everpcpc commented on this pull request.

In platform/mesos/executor.go https://github.com/bilibili/overlord/pull/131#discussion_r454094442:

@@ -238,7 +238,7 @@ func (ec *Executor) Run(c context.Context) { log.Infof("gracefully exiting because framework checkpointing is NOT enabled") return }

• if time.Now().Sub(disconnected) > ec.cfg.RecoveryTimeout {
• if time.Since(disconnected) > ec.cfg.RecoveryTimeout {

time.Since is just a shorthand for time.Now().Sub and suggested by golint.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bilibili/overlord/pull/131#discussion_r454094442, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBQJUMCJ3UCQ4NLKPEWI3TR3PODFANCNFSM4NZAKS4A .

-- 欢天喜地敲锣鼓，开开心心搞优化