bilingualgeneration / bili-app

1 stars 0 forks source link

Onboarding - required element, google/apple email capacity missing #137

Closed mariedr closed 9 months ago

mariedr commented 9 months ago

-Your full name should be required field (missing in teacher onboarding only) -Should allow google and apple emails (both language versions)

Screenshot 2024-01-23 at 9 53 25 AM
jonathan-chin commented 9 months ago

Your full name should be required field (missing in teacher onboarding only)

good catch! @amak-code can you fix this? you should just need to pass the required={true} prop in the correct place.

Should allow google and apple emails (both language versions)

this is SSO sign up, using your Google and/or Apple account. it requires a good chunk of dev time and it's pretty low on our priority list. maybe we can remove it from the MVP for now?

jonathan-chin commented 9 months ago

this is in /pages/SignUp/TeacherAccountCredentials.tsx

for the SSO options and the or divider, you should be able to just add ion-hide to the classes

amak-code commented 9 months ago

Fixed in commit: Teacher sign up form was fixed