search

billcobbler / casbin-redis-watcher

Redis watcher for Casbin https://github.com/casbin/casbin
Apache License 2.0
19 stars 23 forks source link

How can I handle watcher when redis host is down or not available #16

Closed cantv6605-seta closed 3 years ago

cantv6605-seta commented 3 years ago

@billcobbler @moranmathias @dallen42 @rwbarber2 @henrykin I'm testing in case watcher connected to Redis host but for some reasons Redis host is down or not available or ... Currently, in this case, I see a lot of error messages like Failure from Redis subscription: write tcp 192.168.80.133:44120->192.168.80.133:6379: use of closed network connection It repeats forever, how can I handle this? It is blocking my program image

Thanks!

cantv6605-seta commented 3 years ago

@billcobbler Could you take a look?

hsluoyz commented 3 years ago

@00LT00 can you also take a look at this issue?

cantv6605-seta commented 3 years ago

@all Can someone help to take a look at this? can we reconnect to redis host in this case?

hsluoyz commented 3 years ago

@cantv6605-seta forked here: https://github.com/casbin/redis-watcher as it seems there's already no response for 6 days..

billcobbler commented 3 years ago

Hey @cantv6605-seta, this looks like the behavior reported in #14. I just haven't had time to work on it.

hsluoyz commented 3 years ago

Hi @billcobbler , to better maintain this project, can we put this repo inside casbin org? Specifically:

  1. You will join Casbin as a member.
  2. You can still maintain the project in: https://github.com/casbin/redis-watcher . Other Casbin team members will also help you maintain it.

Let me know if it sounds OK for you. Thanks!

billcobbler commented 3 years ago

I'm happy to review any PRs y'all want to submit.

cantv6605-seta commented 3 years ago

I'm happy to review any PRs y'all want to submit.

@billcobbler Can I have permission to create/submit a PR? I got 403 error when pushing a new branch. Thanks!

billcobbler commented 3 years ago

@cantv6605-seta you just need to fork and submit a PR from your fork. But I also just pushed up #17 if you want to give that a shot and confirm it works for you.

cantv6605-seta commented 3 years ago

@billcobbler Could you help to release a new latest version for go modules? Looks like the latest version for go mod is old 52f9bd47d420

billcobbler commented 3 years ago

You bet, just released v1.0.1