Support special username in Redis AUTH

billcobbler / casbin-redis-watcher

Redis watcher for Casbin https://github.com/casbin/casbin

Apache License 2.0

19 stars 23 forks source link

Closed cantv6605-seta closed 3 years ago

cantv6605-seta commented 3 years ago

@billcobbler My project needs to use a special username to connect Redis Can you help to review this PR? Some changes:

hsluoyz commented 3 years ago

@cantv6605-seta plz fix CI.

billcobbler commented 3 years ago

@cantv6605-seta thanks for the PR, this looks good to me!

hsluoyz commented 3 years ago

@billcobbler it seems the CI is failing, can you take a look at this issue: https://github.com/billcobbler/casbin-redis-watcher/issues/20 ?

cantv6605-seta commented 3 years ago

@cantv6605-seta thanks for the PR, this looks good to me!

@billcobbler Can we merge this PR? Thanks!

cantv6605-seta commented 3 years ago

If you help to release a new version that should be good. Many thanks!

hsluoyz commented 3 years ago