search

billdami / ember-date-picker

A lightweight, mobile-optimized, date picker component for ember.js applications.
MIT License
28 stars 8 forks source link

Date Picker does not open after updating EmberJS to version 1.8 #2

Open ralph opened 10 years ago

ralph commented 10 years ago

Hello,

unfortunately, the date picker does not open any more after updating Ember to version 1.8 (the one including metal views). Here is a fork demonstrating the behaviour: https://github.com/ralph/ember-date-picker

I only changed the EmberJS bower dependency, ran bower install and opened the example html file. Unfortunately, I could not figure out what is going wrong yet.

Regards Ralph

kwal commented 10 years ago

I think this might be caused by the fact that the templates are pre-compiled, both for this control and for the spinner on which it's dependent. The inclusion of MetalViews within 1.8 would require that these templates are re-generated.

ralph commented 10 years ago

Good point @Kwal :)

billdami commented 10 years ago

Sorry for the delay on this guys, I've just been super busy with other commitments lately and haven't had the time to maintain this or ember-spin-box as much as I'd like to.

I will do my best to try to get this updated to work under 1.8+ as soon as I can, but I'd be more than happy to accept pull requests as well. :-)

ralph commented 10 years ago

I totally understand, I haven't committed anything to open source lately. :(

That being said, I've replaced ember-date-picker with some simpler Bootstrap based controls in my current project, as it turned out I didn't need a full fledged date picker after all. So the probability that I'll pick this up is pretty low, to be honest.

Stil, your date picker is awesome, and I hope it will live on! :)

kwal commented 10 years ago

No problem - thanks for putting this out there in the first place =)

tananrules commented 10 years ago

@billdami your date-picker is awesome. waiting eagerly to see it working in ember 1.8