billdeitrick / pypco

A Python client for the Planning Center Online API.
MIT License
39 stars 13 forks source link

Added Try Catch for KeyError when no relationships returned #32

Closed pastorhudson closed 4 years ago

pastorhudson commented 4 years ago

Feel free to merge this if it's helpful. No, I don't want to add a test :rofl:

codecov[bot] commented 4 years ago

Codecov Report

Merging #32 into 1.0-dev will increase coverage by 2.41%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           1.0-dev      #32      +/-   ##
===========================================
+ Coverage    96.38%   98.79%   +2.41%     
===========================================
  Files            9        4       -5     
  Lines          553      166     -387     
===========================================
- Hits           533      164     -369     
+ Misses          20        2      -18
Impacted Files Coverage Δ
pypco/pco.py 98.19% <100%> (-1.81%) :arrow_down:
pypco/user_auth_helpers.py 100% <0%> (ø) :arrow_up:
pypco/__init__.py
tests/test_user_auth_helpers.py
tests/__init__.py
tests/test_pco.py
tests/test_auth_config.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51a98e5...8cd1d84. Read the comment docs.

billdeitrick commented 4 years ago

Fixed in 7a1c1a3b2e7b524bdc7265c7f7ad1167df5fff55; see #30. Thanks for finding and reporting this! 🙂

pastorhudson commented 4 years ago

Glad to help! Your solution is definitely better.